DirectorySearch Exchange
Search All Sites
Nagios Live Webinars
Let our experts show you how Nagios can help your organization.Login
New ListingsDirectory Tree
Directory
kpike
bykpike, July 18, 2012
First off, thank you for contributing. But here is some constructive criticism.
- Learn how to compress a file, why would you compress it twice?
- Inefficient Perl programming, the plugin uses a wget to grab the xml from jkstatus/?mime=xml ... Why not just use XML::Simple and slurp it directly into a hashref? my $xml = XMLin($url). Since your already using LWP. Just look at some of the apache status plugins for an example.
I am re-writing and will be uploading the updated plugin.
- Learn how to compress a file, why would you compress it twice?
- Inefficient Perl programming, the plugin uses a wget to grab the xml from jkstatus/?mime=xml ... Why not just use XML::Simple and slurp it directly into a hashref? my $xml = XMLin($url). Since your already using LWP. Just look at some of the apache status plugins for an example.
I am re-writing and will be uploading the updated plugin.
